Placemark New Features #1263
Merged
Placemark New Features #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bldrs-share-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…exists there. * set up state for editable issues + edit bodies for proper placemark insertion * add cancel edit button to leave editing state in notes
nickcastel50
had a problem deploying
to
cypress
GitHub Actions
Failure
nickcastel50
had a problem deploying
to
cypress
GitHub Actions
Failure
pablo-mayrgundter
added this to the Notes 200: Research existing Placemark code milestone
pablo-mayrgundter
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored and implemented New Placemarks Version
Features:
Testing
Select the different markers to see the URL change and current issue / comment note update in the UI.
To place a placemark, click into an issue thread. If you are logged in, you will see a placemark Icon on the main issue and on the "leave a comment" UI elements. To leave one on an existing issue, go to edit issue and then click the marker icon for the issue. To leave one on a comment, click the marker icon on the new comment UI element. Then, double click anywhere on the model.